Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a proof-of-concept for importing coffeelint.json from parent directories #11

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

hdavidzhu
Copy link
Contributor

@hdavidzhu hdavidzhu commented Dec 14, 2018

This PR attempts to use the built-in coffeelint/configfinder to locate coffeelint.json defined in a parent directory.

For my dev environment, I keep a coffeelint.json in the parent directory, and I do not include a coffeelint.json in the workspace directory of my project.

This implementation is based off of:

clutchski/coffeelint#570 (comment)

Issues

  • I don't use Typescript, and I had a very hard time trying to compile. I can't get past some compile errors for vscode. I have no idea if this code works.
  • I also struggled to get the extension dev environment set up for vscode. It's more effort than I have time for.

If you could include a README for this extension of development, I'd really appreciate it! Thanks for building this linter extension.

NOTE: This code is not tested and probably does NOT work

@hdavidzhu hdavidzhu requested a review from lkytal January 31, 2020 21:24
@lkytal lkytal merged commit 7a76489 into lkytal:master Feb 7, 2020
@hdavidzhu
Copy link
Contributor Author

@lkytal Hmmm, did you verify that this works? I certainly did not... 🙏

@lkytal
Copy link
Owner

lkytal commented Feb 7, 2020

@lkytal Hmmm, did you verify that this works? I certainly did not... 🙏

Hi, this just means that I accept this idea. I'll release an update once I finish it, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants